Browse Source

Implemented code-review feedback

pull/172/head
Michael Olund 5 years ago
parent
commit
fecb34e9e7
3 changed files with 2 additions and 4 deletions
  1. +1
    -1
      edivorce/apps/core/serializer.py
  2. +0
    -1
      edivorce/apps/core/tests/test_upload.py
  3. +1
    -2
      edivorce/apps/core/validators.py

+ 1
- 1
edivorce/apps/core/serializer.py View File

@ -3,7 +3,7 @@ from rest_framework import serializers
from rest_framework.exceptions import ValidationError
from .models import Document, UserResponse
from .validators import *
from .validators import file_scan_validation, valid_file_extension, valid_doc_type, valid_rotation
class UserResponseSerializer(serializers.ModelSerializer):


+ 0
- 1
edivorce/apps/core/tests/test_upload.py View File

@ -5,7 +5,6 @@ from unittest import mock
from django.test import TestCase
from django.core.files.uploadedfile import SimpleUploadedFile
from rest_framework import serializers
from rest_framework.test import APIRequestFactory
from ..validators import file_scan_validation
from ..models import Document


+ 1
- 2
edivorce/apps/core/validators.py View File

@ -2,7 +2,6 @@ import logging
import clamd
import sys
from rest_framework import serializers
from rest_framework.exceptions import ValidationError
from django.conf import settings
@ -59,4 +58,4 @@ def valid_doc_type(value):
def valid_rotation(value):
if value % 90 != 0:
raise serializers.ValidationError('Rotation must be 0, 90, 180, or 270')
raise ValidationError('Rotation must be 0, 90, 180, or 270')

Loading…
Cancel
Save