Updated error handling to reduce nesting

edivorce/apps/core/utils/cso_filing.py

@@ -28,23 +28,22 @@ def file_documents(request, responses, initial=False):
     if errors:
         return errors, None
 
-    if settings.EFILING_HUB_ENABLED:
-        hub = EFilingHub(initial_filing=initial)
-
-        post_files, documents = hub.get_files(request, responses, uploaded, generated)
-        location = hub.get_location(responses)
-        parties = hub.get_parties(responses)
+    if not settings.EFILING_HUB_ENABLED:
+        return after_file_documents(request, initial)
 
-        redirect_url, msg = hub.upload(request, post_files, documents, parties, location)
+    hub = EFilingHub(initial_filing=initial)
+    post_files, documents = hub.get_files(request, responses, uploaded, generated)
+    location = hub.get_location(responses)
+    parties = hub.get_parties(responses)
 
-        if redirect_url:
-            return errors, redirect_url
+    redirect_url, msg = hub.upload(request, post_files, documents, parties, location)
 
-        if msg:
-            return msg, None
+    if msg:
+        errors.append(msg)
+        return errors, None
 
-    else:
-        return after_file_documents(request, initial)
+    if redirect_url:
+        return None, redirect_url
 
     return None, None